This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Float64 fallback for mkldnn subgraph and rnn op #15853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhennanQin
force-pushed
the
float64_fallback
branch
from
August 12, 2019 03:17
cbb6692
to
9147b38
Compare
@ZhennanQin could you try CI again? |
@ZhennanQin @xinyu-intel please retrigger the CI |
ZhennanQin
force-pushed
the
float64_fallback
branch
from
August 27, 2019 01:04
4fefd84
to
5ea26ed
Compare
Change-Id: I472fb7bbffc16ed8c36494ab49838b08c59b2f12
Change-Id: Iecfef9e30e8fecd3bcb97b336ece0116a204c6f1
@ZhennanQin could you resolve the conflict and I will merge this one? |
pengzhao-intel
approved these changes
Sep 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the dmlc-core to the official repo.
Change-Id: Ia39ea4e373a78a4dbf50861fe62dcd2bdcc2bea1
Change-Id: I5a27dc83b892bf8fcb34bb089449d1d3b6e9beed
ZhennanQin
force-pushed
the
float64_fallback
branch
from
September 16, 2019 06:10
5cea4a5
to
48a6ef3
Compare
…64_fallback Change-Id: Ib5afeb70cdf9cf20a0551a1a38fad93d70a486bb
Change-Id: I36cbffe0dcd391ad379abbe5641b2234fd9a0946
Change-Id: I285947e01bdb0651c2c7830ed4eb76931a09b754
@ZhennanQin Try CI again? |
Change-Id: Iced43c2e411ac663540ebf5c7c355b6e06a29775
Change-Id: I6f23b51d6bda44f6ae18766ebe390118740bb9c7
Change-Id: Ica49bc6e5eea4711ce36ee69215e9aabb93e84cc
@pengzhao-intel Finally, finally, this got CI passed. |
Thanks a lot, really difficult :( Merging now. |
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* Fix mkldnn subgraph with float64 * Fix ci Change-Id: I0bb4e8d7a0a534aa661601887cc633cb9c4fcadf * Fix test Change-Id: I96c529abe7adb6def90a22f03b3432263ef12fda * Update dmlc-core Change-Id: I472fb7bbffc16ed8c36494ab49838b08c59b2f12 * pin to offical dmlc Change-Id: I5a27dc83b892bf8fcb34bb089449d1d3b6e9beed * Fix GPU CI Change-Id: I285947e01bdb0651c2c7830ed4eb76931a09b754 * Fix GPU CI Change-Id: I6f23b51d6bda44f6ae18766ebe390118740bb9c7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can resolve #15767.
@PatricZhao @TaoLv @ciyongch @reminisce
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments